The XSL I wrote below works, but I'm looking for ways to improve my
coding style. Is this a bad way of writing style sheets? - in
particular the fact that I call "apply-templates" about a million
times.

<xsl:apply-templates></xsl:apply-templates>
can be rewritten as <xsl:apply-templates/>