if I understand what you mean then change


<xsl:template name="ReplaceHyphenWithUnderscore">
   <xsl:analyze-string select="@name" regex="-">


to


<xsl:template match="@*" mode="ReplaceHyphenWithUnderscore">
   <xsl:analyze-string select="." regex="-">



then in whichever template where you want this do

<xsl:attribute name="something">
 <xsl:apply-templates select="@something" mode="ReplaceHyphenWithUnderscore"/>


David

________________________________________________________________________
The Numerical Algorithms Group Ltd is a company registered in England
and Wales with company number 1249803. The registered office is:
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.

This e-mail has been scanned for all viruses by Star. The service is
powered by MessageLabs. 
________________________________________________________________________